Skip to content

Restore sanitizer constructor-order diagnostics - #1563

Open
bmehta001 wants to merge 1 commit into
microsoft:mainfrom
bmehta001:cleanup-sanitizer-reorder
Open

bmehta001 wants to merge 1 commit into
microsoft:mainfrom
bmehta001:cleanup-sanitizer-reorder

Conversation

@bmehta001

Copy link
Copy Markdown
Contributor

Summary

  • Remove the obsolete -Wno-reorder suppression and its outdated rationale. The pinned modules commit already initializes sanitizer members in declaration order.

Validation

  • WSL Ubuntu 24.04 / GCC 13: compiled the actual Sanitizer.cpp target with -Werror and verified -Wno-reorder was absent — passed.
  • Windows: cmake --build out\vs2026 --config Debug --target mat --parallel 8 with Visual Studio 2026 and the pinned modules — passed.
  • No runtime tests were run for this compile-only change.

The pinned sanitizer already initializes members in declaration order, so remove the obsolete suppression and its stale rationale.

Files: lib/CMakeLists.txt

Co-authored-by: Copilot <[email protected]>
Copilot-Session: f7e2f450-c2c4-43c5-9fb1-05fa4f7d8e9e
@bmehta001
bmehta001 requested a review from a team as a code owner November 19, 2026 18:04
@bmehta001
bmehta001 enabled auto-merge (squash) November 19, 2026 18:04
@bmehta001

Copy link
Copy Markdown
Contributor Author

CI note: the Ubuntu runner-contract and GCC/Clang public-header failures also occur on unchanged main (c7761eb4; https://github.com/microsoft/cpp_client_telemetry/actions/runs/44442208907). The macOS runner-contract sibling was cancelled. Existing PR #1562 fixes both baseline issues, and its corresponding checks pass. Neither failed job is a required branch-protection context.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant